Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Work around NPE for toolwindow #5665

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Work around NPE for toolwindow #5665

merged 1 commit into from
Nov 13, 2023

Conversation

dkashyn-sfdc
Copy link
Contributor

@dkashyn-sfdc dkashyn-sfdc commented Nov 9, 2023 •
edited
Loading

Checklist

  • I have filed an issue about this change and discussed potential changes with the maintainers.
  • I have received the approval from the maintainers to make this change.
  • This is not a stylistic, refactoring, or cleanup change.

Please note that the maintainers will not be reviewing this change until all checkboxes are ticked. See
the Contributions section in the README for more
details.

Discussion thread for this change

Issue number: 5664

Description of this change

@github-actions github-actions bot added product: CLion CLion plugin product: IntelliJ IntelliJ plugin product: GoLand GoLand plugin awaiting-review Awaiting review from Bazel team on PRs labels Nov 9, 2023
@ujohnny
Copy link
Collaborator

ujohnny commented Nov 10, 2023

So the workaround might lead to the bug that the most recent console might not be selected, but I think it's ok to have this behavior rather than have the exception. I was trying to find a root cause why the event comes before the console added, but the behavior is a bit obscure.

@blorente
Copy link
Collaborator

I agree that it might cause a not-most-recent console to be selected, but also this would have been the behaviour if the NPE didn't raise, so I think it's a fine workaround.

@dkashyn-sfdc
Copy link
Contributor Author

In my case no user action was even required. I was able to repro issue both in local: during working with IJWB plugin itself and starting 2023.3 (it was not the thing before) and with Gateway mode.

In both cases we are launching IJ with project specified in CLI and by the time user opens UI there are such exception, without any user action.

@blorente blorente merged commit 2397056 into bazelbuild:master Nov 13, 2023
8 checks passed
@github-actions github-actions bot removed the awaiting-review Awaiting review from Bazel team on PRs label Nov 13, 2023
@tpasternak tpasternak linked an issue Nov 15, 2023 that may be closed by this pull request
Exception during IJ startup with Bazel plugin when Bazel project opened by default #5664
Closed
This was referenced Nov 15, 2023
Closed
Closed
Closed
Merged
@tpasternak tpasternak mentioned this pull request Nov 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blorente blorente blorente approved these changes

@mai93 mai93 Awaiting requested review from mai93 mai93 is a code owner

@jastice jastice Awaiting requested review from jastice

@tpasternak tpasternak Awaiting requested review from tpasternak tpasternak is a code owner

@agluszak agluszak Awaiting requested review from agluszak agluszak is a code owner

Assignees

@tpasternak tpasternak

@blorente blorente

@mai93 mai93

Labels
product: CLion CLion plugin product: GoLand GoLand plugin product: IntelliJ IntelliJ plugin
Projects
Bazel IntelliJ Plugin
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Exception during IJ startup with Bazel plugin when Bazel project opened by default
5 participants
@dkashyn-sfdc @ujohnny @blorente @tpasternak @mai93